Create veng-timer#11608
Open
Divine-Dream wants to merge 3 commits into
Open
Conversation
|
New plugin |
|
Internal use only: Reviewer details Maintainer details |
had to remove debugging messages in chatbox
This comment was marked as outdated.
This comment was marked as outdated.
riktenx
added
the
waiting for author
riktenx
removed
the
waiting for author
Member
|
add |
riktenx
added
the
waiting for author
Contributor
Author
|
I just noticed this comment, was waiting a bit and forgot I even made this. Would I need to make this plugin fail in areas like pvp minigames and stuff? tbh I only added those checks because I assumed it would avoid a revision in case it was against the rules. Let me know what you need from me! I'd love to have this plugin |
runelite-github-app
Bot
removed
the
waiting for author
Contributor
Author
|
do you have any advice on how I can just make this exclusive to party members only? that way the pvp checks aren't even a real concern, since you'd have to be in a party to even see the timer anyway? |
riktenx
added
the
waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this plugin displays a visual countdown of player's veng timers.
I made sure to disable this for pvp worlds/areas